Skip to content

chore: mypy and additional type annotations #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 30, 2022
Merged

chore: mypy and additional type annotations #362

merged 12 commits into from
May 30, 2022

Conversation

tony
Copy link
Member

@tony tony commented May 29, 2022

make mypy

make watch_mypy

@codecov
Copy link

codecov bot commented May 29, 2022 •
edited
Loading

Codecov Report

Merging #362 (7067d0f) into master (0f89303) will increase coverage by 0.08%.
The diff coverage is 77.27%.

❗ Current head 7067d0f differs from pull request most recent head 5fa1915. Consider uploading reports for the commit 5fa1915 to get more accurate results

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
+ Coverage   70.26%   70.35%   +0.08%     
==========================================
  Files          21       21              
  Lines        1860     1882      +22     
==========================================
+ Hits         1307     1324      +17     
- Misses        553      558       +5
Impacted Files Coverage Δ
libvcs/cmd/git.py 54.16% <0.00%> (ø)
libvcs/cmd/svn.py 52.23% <ø> (ø)
tests/projects/test_base.py 100.00% <ø> (ø)
libvcs/projects/git.py 76.53% <73.33%> (-1.00%) ⬇️
docs/conf.py 62.76% <100.00%> (ø)
libvcs/projects/base.py 100.00% <100.00%> (ø)
tests/projects/test_git.py 99.41% <100.00%> (+0.03%) ⬆️
tests/projects/test_svn.py 96.00% <100.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f89303...5fa1915. Read the comment docs.

@tony tony force-pushed the mypy-corrections branch 8 times, most recently from 00c710f to 60de043 Compare May 30, 2022 16:37
@tony tony added this to the v0.13 milestone May 30, 2022
@tony tony force-pushed the mypy-corrections branch 11 times, most recently from 3732894 to 10e93a6 Compare May 30, 2022 20:59
@tony tony mentioned this pull request May 30, 2022
Closed
@tony tony force-pushed the mypy-corrections branch 2 times, most recently from 35cb859 to a686b6a Compare May 30, 2022 21:23
@tony tony force-pushed the mypy-corrections branch from a686b6a to d7c75db Compare May 30, 2022 21:34
@tony tony linked an issue May 30, 2022 that may be closed by this pull request
mypy: Initial setup #367
Closed
@tony tony changed the title chore: mypy type corrections chore: mypy and additional type annotations May 30, 2022
@tony tony force-pushed the mypy-corrections branch from 67a1a63 to 7067d0f Compare May 30, 2022 21:54
@tony tony merged commit c06b8ed into master May 30, 2022
@tony tony deleted the mypy-corrections branch May 30, 2022 22:00
@tony tony mentioned this pull request May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13
Development

Successfully merging this pull request may close these issues.

mypy: Initial setup
1 participant
@tony