Issue: mercurial / svn missing skips git tests
#482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #482 +/- ##
==========================================
- Coverage 54.08% 54.01% -0.07%
==========================================
Files 40 40
Lines 3635 3634 -1
Branches 793 794 +1
==========================================
- Hits 1966 1963 -3
- Misses 1318 1319 +1
- Partials 351 352 +1 ☔ View full report in Codecov by Sentry. |
d78f84d to
6436c03
Compare
6436c03 to
6927e42
Compare
6927e42 to
fb20670
Compare
|
@sourcery-ai review |
Reviewer's Guide by SourceryThis pull request fixes an issue where tests were skipped if certain VCS binaries were missing, but the tests didn't rely on those binaries. The logic was unintentionally skipping tests that should have run. The fix now correctly skips tests only when the required VCS binary is missing. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @tony - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+117
to
+121
| if any( # NOQA: SIM103 | ||
| needle in str(collection_path) for needle in ["hg", "mercurial"] | ||
| ) and not shutil.which("hg"): | ||
| return True | ||
| return False |
There was a problem hiding this comment.
issue (code-quality): We've found these issues:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp) - Simplify boolean if expression (
boolean-if-exp-identity) - Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If
svn(subversion) orhg(mercurial) isn't installed, fixtures for git-based tests won't run.Summary by Sourcery
Tests: