remove config extract magic #362
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tony
added a commit
to vcs-python/libvcs
that referenced
this pull request
Mar 27, 2022
tony
added a commit
to vcs-python/libvcs
that referenced
this pull request
Apr 1, 2022
Fixes #311 for use in vcs-python/vcspull#362
${HOME}/develop/github.com/vcs-python/checkouts:
dotfiles:
vcs: git
options:
remotes:
origin: ssh://git@gitlab.com/Segaja/dotfiles.git
procpath:
vcs: hg
options:
url: https://heptapod.host/saajns/procpath
subversion:
vcs: svn
options:
url: https://svn.apache.org/repos/asf/subversion/trunk
~/develop/github.com/vcs-python/checkouts2:
discordbot:
vcs: git
options:
remotes:
origin: ssh://git@gitlab.com/Segaja/discordbot.git~/develop/github.com/vcs-python/checkouts3:
discordbot:
vcs: git
options:
remotes:
origin: ssh://git@gitlab.com/Segaja/discordbot.git |
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
|
@Segaja Nice rebase. 💪 |
tony
added a commit
to vcs-python/libvcs
that referenced
this pull request
May 29, 2022
To make passing as a configuration file (#315 and vcs-python/vcspull#362) easier, deprecate positional arguments. See also: - PEP 570: https://peps.python.org/pep-0570/ - https://peps.python.org/pep-0570/#:~:text=def%20kwd_only_arg*%2C%20arg)(%3A)
tony
added a commit
to vcs-python/libvcs
that referenced
this pull request
May 29, 2022
To make passing as a configuration file (#315 and vcs-python/vcspull#362) easier, deprecate positional arguments. See also: - PEP 570: https://peps.python.org/pep-0570/ - https://peps.python.org/pep-0570/#:~:text=def%20kwd_only_arg*%2C%20arg)(%3A)
tony
added a commit
that referenced
this pull request
May 29, 2022
To make #362 easier, make sure projects only accept keyword arguments. This eliminates any ambiguity of arguments not double-splatable via **.
tony
reviewed
Jun 19, 2022
Comment on lines
+189
to
+195
| for parent_path, repos in config2.items(): | ||
| if parent_path in config1: | ||
| for name, repo in repos.items(): | ||
| if name in config1[parent_path]: | ||
| dupes += (repo, config1[parent_path][name]) | ||
|
|
||
| if not path_duplicates: | ||
| return None | ||
| return dupes |
There was a problem hiding this comment.
This is the area I used in #373 (but changed a lot)
220944d to
9d19f42
Compare
0ec0af6 to
7f76836
Compare
54b2d28 to
b9c0aa1
Compare
8fc02b0 to
af8cafc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #360
vcspull sync <url>