-
Notifications
You must be signed in to change notification settings - Fork 29k
docs: add typescript switcher to logging.mdx #75172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
Conversation
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
546020c
to
5579716
Compare
725a6df
to
7479cd5
Compare
fce57e2
to
3ecca16
Compare
|
4d9e092
to
062f950
Compare
4915bdd
to
887bf77
Compare
const nextConfig: NextConfig = { | ||
logging: { | ||
incomingRequests: { | ||
ignore: [/\api\/v1\/health/], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a syntax error in the regular expression. The backslash before api
is unnecessary and could cause the regex to not match as expected. The correct pattern should be /api\/v1\/health/
instead of /\api\/v1\/health/
.
- ignore: [/\api\/v1\/health/],
+ ignore: [/api\/v1\/health/],
ignore: [/\api\/v1\/health/], | |
ignore: [/\api\/v1\/health/], |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
1a084e4
to
07951eb
Compare
const nextConfig: NextConfig = { | ||
logging: { | ||
incomingRequests: { | ||
ignore: [/\api\/v1\/health/], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a syntax error in the regular expression pattern. The backslash before api
is unnecessary and could cause the pattern to not match as expected. The correct pattern should be:
/api\/v1\/health/
The extra backslash before "api" should be removed while maintaining the escaped forward slashes.
ignore: [/\api\/v1\/health/], | |
ignore: [/\api\/v1\/health/], |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
ce59d17
to
1765ca9
Compare
d004ffe
to
bf61819
Compare
5c2de40
to
f79e828
Compare
9d70f9f
to
ecd36c8
Compare
5e380b0
to
d6b973c
Compare
Summary
Follow up #74349.
Add
next.config.ts
code block to logging docs.Improving Documentation
pnpm prettier-fix
to fix formatting issues before opening the PR.