Skip to content

docs: add typescript switcher to logging.mdx #75172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

JamBalaya56562
Copy link
Contributor

Summary

Follow up #74349.
Add next.config.ts code block to logging docs.

Improving Documentation

@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Jan 22, 2025
@ijjk
Copy link
Member

ijjk commented Jan 22, 2025

Allow CI Workflow Run

  • approve CI run for commit: d6b973c

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link

changeset-bot bot commented May 15, 2025

⚠️ No Changeset found

Latest commit: 887bf77

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JamBalaya56562 JamBalaya56562 force-pushed the logging branch 3 times, most recently from 4d9e092 to 062f950 Compare May 22, 2025 01:10
@JamBalaya56562 JamBalaya56562 force-pushed the logging branch 5 times, most recently from 4915bdd to 887bf77 Compare May 29, 2025 23:28
const nextConfig: NextConfig = {
logging: {
incomingRequests: {
ignore: [/\api\/v1\/health/],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a syntax error in the regular expression. The backslash before api is unnecessary and could cause the regex to not match as expected. The correct pattern should be /api\/v1\/health/ instead of /\api\/v1\/health/.

- ignore: [/\api\/v1\/health/],
+ ignore: [/api\/v1\/health/],
Suggested change
ignore: [/\api\/v1\/health/],
ignore: [/\api\/v1\/health/],

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@JamBalaya56562 JamBalaya56562 force-pushed the logging branch 3 times, most recently from 1a084e4 to 07951eb Compare June 19, 2025 00:08
const nextConfig: NextConfig = {
logging: {
incomingRequests: {
ignore: [/\api\/v1\/health/],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a syntax error in the regular expression pattern. The backslash before api is unnecessary and could cause the pattern to not match as expected. The correct pattern should be:

/api\/v1\/health/

The extra backslash before "api" should be removed while maintaining the escaped forward slashes.

Suggested change
ignore: [/\api\/v1\/health/],
ignore: [/\api\/v1\/health/],

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@JamBalaya56562 JamBalaya56562 force-pushed the logging branch 5 times, most recently from d004ffe to bf61819 Compare July 4, 2025 03:53
@JamBalaya56562 JamBalaya56562 force-pushed the logging branch 3 times, most recently from 5c2de40 to f79e828 Compare July 11, 2025 00:42
@JamBalaya56562 JamBalaya56562 force-pushed the logging branch 4 times, most recently from 9d70f9f to ecd36c8 Compare July 22, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Related to Next.js' official documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants