fix: use waitUntil if available to await the fetch cache set promise
#75971
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
ijjk
reviewed
Apr 28, 2025
| @@ -727,6 +728,15 @@ export function createPatchedFetcher( | |||
| ) | |||
| .finally(handleUnlock) | |||
|
|
|||
| const waitUntil = getBuiltinRequestContext()?.waitUntil | |||
There was a problem hiding this comment.
Instead of pulling in the RequestContext here we could push this onto the pendingRevalidates array which already gets wired to the available waitUntil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The promise created for updating the incremental cache on successful fetches is not used, returned nor awaited in any way. I imagine that this can be fine in environments such as Node.js servers where the dangling promise will eventually run, in other environments however the promise might be cancelled causing the cache update not to happen, so it would be appropriate, when possible that the promise is awaited using
waitUntil(for more context, I've encountered this issue in the OpenNext project).cc. @vicb, @conico974