test: flake debugging - avoid logs being eaten by jest #78449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11b0985 to
f88e389
Compare
huozhi
approved these changes
Apr 23, 2025
lubieowoce
added a commit
that referenced
this pull request
Apr 23, 2025
This reverts commit f42ba51.
lubieowoce
added a commit
that referenced
this pull request
Apr 23, 2025
Some tests in `rsc-basic` asserts that certain nodes should be empty, but streaming metadata can get in there and break that expectation. - i switched the test to use a full browser. this is better than checking the raw html, because then react gets rid of any `<template>` tags inside the div (which are used for streaming SSR things) - we're also now only asserting that the inner text of the node should be empty, which avoids failures because of a `<div hidden>` inserted by streaming metadata. this is a slightly weaker assertion than "this node has no children at all" but it should be enough for our purposes here. also reverts #78449 and #78424, they were meant for debugging this issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #78424. annoyingly, it appears that the console.log output gets swallowed by jest somehow, so i'm using
require('console')instead which jest doesn't instrument.