refactor(flight): Centralise logic for generating module manifest keys #78517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
d27a51d to
8afa648
Compare
8afa648 to
39521f1
Compare
39521f1 to
e6f4858
Compare
623737b to
f34488b
Compare
187f61e to
e8562b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unifies resource-key generation via a shared
getModuleResourceKey()helper, so client, server, and edge compilers reference modules with the same canonical string (path + query + barrel suffix, normalised + relative).Removes bespoke key logic from the flight loader, client-entry, and manifest plugins; all delegate to the helper to avoid drift. The manifest now retains query strings for named module IDs (enabling userland "use client" virtual modules). This was used inconsistently before. Turbopack’s "use client" proxy also now includes
ctx.query_strfor parity.Also a drive-by fix to make sure
pluginState.edgeRscModulesis actually used for edge RSC mapping.