Skip to content

fix: broken deploy test from #77898 #78692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

fix: broken deploy test from #77898 #78692

merged 1 commit into from
Apr 30, 2025
+30 −22

Conversation

lubieowoce
Copy link
Member

@lubieowoce lubieowoce commented Apr 30, 2025 •
edited
Loading

i messed up a deployment test thing in #77898, had the fix locally but forgot to push before merging. the test tries to wait for some initial stuff to happen stuff after the deployment finishes, but we should only to do that once, it won't work in the second test of the it.each, so the test fails.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. tests labels Apr 30, 2025
@lubieowoce lubieowoce changed the title fix: broken test in deploy fix: broken test in deploy from #77898 Apr 30, 2025
@lubieowoce lubieowoce changed the title fix: broken test in deploy from #77898 fix: broken deploy test from #77898 Apr 30, 2025
@lubieowoce lubieowoce marked this pull request as ready for review April 30, 2025 03:47
@ijjk
Copy link
Member

ijjk commented Apr 30, 2025

Failing test suites

Commit: b68beb9

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/app-dir/app-basepath/index.test.ts (PPR)

  • app dir - basepath > should successfully hard navigate from pages -> app
Expand output

● app dir - basepath › should successfully hard navigate from pages -> app

page.waitForSelector: Timeout 10000ms exceeded.
Call log:
  - waiting for locator('#page-2')

  454 |   waitForElementByCss(selector: string, timeout = 10_000) {
  455 |     return this.startChain(async () => {
> 456 |       const el = await page.waitForSelector(selector, {
      |                             ^
  457 |         timeout,
  458 |         state: 'attached',
  459 |       })

  at waitForSelector (lib/browsers/playwright.ts:456:29)
  at Playwright._chain (lib/browsers/playwright.ts:568:23)
  at Playwright._chain [as startChain] (lib/browsers/playwright.ts:549:17)
  at Playwright.startChain [as waitForElementByCss] (lib/browsers/playwright.ts:455:17)
  at Object.waitForElementByCss (e2e/app-dir/app-basepath/index.test.ts:16:19)

Read more about building and testing Next.js in contributing.md.

@lubieowoce lubieowoce merged commit 9fe8a0c into canary Apr 30, 2025
130 of 132 checks passed
@lubieowoce lubieowoce deleted the lubieowoce/fix-use-cache-deployment-test branch April 30, 2025 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lubieowoce @ijjk