-
Notifications
You must be signed in to change notification settings - Fork 29k
feat: add suffix to rsc txt files for easy routing #80232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
Conversation
@ijjk how can I get and review or reaction on this PR? Is something missing? |
@ijjk is there a chance to get a review on this or maybe at least a reaction? |
eb2a471
to
a446661
Compare
dbc077a
to
4b9a70b
Compare
a0ec6e0
to
92fadeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments:
test/integration/app-dir-export/test/utils.ts (lines 46-59):
The test expectations still reference the old .txt
file extensions, but the export functionality has been updated to generate .rsc.txt
files, which will cause test failures.
View Details
Analysis
The export functionality has been updated across three files to change the file extension from .txt
to .rsc.txt
for RSC (React Server Components) files in export mode. However, the integration test file test/integration/app-dir-export/test/utils.ts
still contains expected file lists that reference the old .txt
extensions.
Specifically, the expectedWhenTrailingSlashTrue
array (lines 46-59) and expectedWhenTrailingSlashFalse
array (lines 76-89) expect files like:
index.txt
another/index.txt
another/first/index.txt
client/index.txt
- etc.
But the actual export process now generates files with .rsc.txt
extensions instead. This mismatch will cause integration tests to fail because they'll be looking for files that no longer exist with the old naming pattern.
Recommendation
Update all .txt
references in the expected file arrays to .rsc.txt
:
In expectedWhenTrailingSlashTrue
:
- Change
'another/first/index.txt'
to'another/first/index.rsc.txt'
- Change
'another/index.txt'
to'another/index.rsc.txt'
- Change
'another/second/index.txt'
to'another/second/index.rsc.txt'
- Change
'client/index.txt'
to'client/index.rsc.txt'
- Change
'image-import/index.txt'
to'image-import/index.rsc.txt'
- Change
'index.txt'
to'index.rsc.txt'
Apply the same pattern to expectedWhenTrailingSlashFalse
(lines 76-89), updating all corresponding .txt
entries to .rsc.txt
except for robots.txt
which should remain unchanged as it's not an RSC file.
07aa7e9
to
c412c12
Compare
0d528a4
to
73f473b
Compare
* enables easy handling for cdns or proxies to identify rsc payloads and route them correctly beside other txt files
73f473b
to
aaf5c2a
Compare
Fixes #80231