Skip to content

Backported Catch the exception thrown by the synchronization to 3.6 #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2019
Merged

Backported Catch the exception thrown by the synchronization to 3.6 #152

merged 2 commits into from
May 27, 2019

Conversation

okou19900722
Copy link
Contributor

fixed #151

@codepitbull
Copy link

Can you provide a test for the situation you are trying to solve with this change?

@okou19900722
Copy link
Contributor Author

  @Test
  public void test(TestContext context){
    JsonArray arr = new JsonArray().add(1).add(2);
    Async async = context.async();
    client.queryWithParams("?", arr, r -> {
      context.assertTrue(r.failed());
      context.assertTrue(r.cause() instanceof InsufficientParametersException);
      async.complete();
    });
  }

https://github.com/jasync-sql/jasync-sql/blob/8e168f442b3175c102bdbeb8e6e706f24962fe8a/mysql-async/src/main/java/com/github/jasync/sql/db/mysql/MySQLConnection.kt#L288-L301

@okou19900722
Copy link
Contributor Author

Callback will never be called before modification

@codepitbull
Copy link

I will review everything this weekend to make sure this doesn't introduce breaking changes for current users.
Thanks for your effort :)

@okou19900722
Copy link
Contributor Author

Hi @codepitbull , have you reviewed yet? It's a terrible problem. can you merge #156 before 3.7.1 release?

@okou19900722 okou19900722 changed the title Catch the exception thrown by the synchronization Backported Catch the exception thrown by the synchronization to 3.6 May 21, 2019
@codepitbull
Copy link

Yes, I already merged the other one. Merging this now.
Sorry for the delay.

@codepitbull codepitbull merged commit f85cf15 into vert-x3:3.6 May 27, 2019
okou19900722 added a commit to okou19900722/vertx-mysql-postgresql-client that referenced this pull request Jun 6, 2019
codepitbull pushed a commit that referenced this pull request Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Exception was discarded, but it shouldn't
3 participants