Skip to content

Fix Interstitials playback with media source transfer #7077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

robwalch
Copy link
Collaborator

This PR will...

Fixes handling of media element transfer between primary and asset HLS.js instances when abutting interstitials have different strategies for appending media (resetting the media source vs using the primary media source in place) and when the underlying primary content spans multiple discontinuities.

Why is this Pull Request needed?

  • Avoids loading and queueing primary init segments for discontinuities obscured by interstitials which could lead improper appends and handling of mixed codecs between primary and interstitial.
  • Maintains asset player currentTime after media is detached
  • Prevent playback from restarting on schedule change after primary media has ended

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.6.0 milestone Mar 10, 2025
@robwalch robwalch requested a review from matvp91 March 10, 2025 20:42
@robwalch robwalch force-pushed the bugfix/interstitials-media-transfer branch from 0d3bc44 to 0fc48a8 Compare March 12, 2025 01:28
@robwalch robwalch changed the title Fix Interstitials playback with shared media element and inconsistent playback/segment duration Fix Interstitials playback with media source transfer Mar 12, 2025
@robwalch robwalch force-pushed the bugfix/interstitials-media-transfer branch from 0fc48a8 to 875df35 Compare March 13, 2025 18:26
@robwalch robwalch merged commit bb86604 into master Mar 13, 2025
16 checks passed
@robwalch robwalch deleted the bugfix/interstitials-media-transfer branch March 13, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant