Skip to content

Guard against exceptions when parsing incomplete codec boxes #7146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Apr 1, 2025

This PR will...

Guard against exceptions when parsing incomplete 'avcC', 'hvcC', 'vpcC', and 'av1C' boxes.

Why is this Pull Request needed?

Internal exceptions are not helpful in troubleshooting bad media.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Resolves #7142

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.6.1 milestone Apr 1, 2025
@robwalch robwalch mentioned this pull request Apr 1, 2025
5 tasks
@robwalch robwalch merged commit 44a9144 into master Apr 2, 2025
16 checks passed
@robwalch robwalch deleted the bugfix/handle-incomplete-stsd-box branch April 2, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to play a fmp4 playlist.
1 participant