Skip to content

Feature/enable synchronizing live start position with program boundary feature 7209 #7211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 5, 2025
Merged

Feature/enable synchronizing live start position with program boundary feature 7209 #7211

merged 12 commits into from
May 5, 2025

Conversation

krseager
Copy link
Contributor

@krseager krseager commented Apr 30, 2025 •
edited by robwalch
Loading

This PR will...

  • Add HLS Config => startOnSegmentBoundary to synchronize start time with main video segment start time
  • Ensure playback start is more stable by aligning start position with segment boundary(ies) to decrease likelihood of buffering soon after video starts

Why is this Pull Request needed?

  • Start Position Calculation currently does not align with segment starts. This means, based on the calculated start time, it could be that playback will start during the middle of a segment rather than the beginning. This leads to less forward buffer available when playback starts, which leads to increased buffering and skips playing part of the first buffered segment(s).

Are there any points in the code the reviewer needs to double check?

  • Ensure Config values & documentation are clear
  • Ensure that logic changed in StreamController looks correct

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@krseager krseager mentioned this pull request Apr 30, 2025
Closed
robwalch
robwalch requested changes Apr 30, 2025
View reviewed changes
@krseager krseager requested a review from robwalch May 1, 2025 17:31
@robwalch robwalch added this to the 1.6.3 milestone May 2, 2025
robwalch
robwalch previously approved these changes May 2, 2025
View reviewed changes
@krseager krseager marked this pull request as ready for review May 2, 2025 02:48
@krseager krseager requested a review from robwalch May 2, 2025 18:52
@krseager
Copy link
Contributor Author

krseager commented May 2, 2025

@robwalch, I added unit tests. Mind re-approving and running CICD so we can get this PR merged? Thanks!

Kyle Seager and others added 3 commits May 2, 2025 14:26
@robwalch robwalch merged commit 80f5c99 into video-dev:master May 5, 2025
12 checks passed
@robwalch robwalch mentioned this pull request May 7, 2025
Merged
3 tasks
@robwalch robwalch moved this from Top priorities to Nice to have in HLS.js Release Planning and Backlog May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robwalch robwalch robwalch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
HLS.js Release Planning and Backlog
Archived in project
Milestone
1.6.3
Development

Successfully merging this pull request may close these issues.
2 participants
@krseager @robwalch