Skip to content

Functional test runner setup changes for running in Safari locally #7313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Jun 11, 2025

This PR will...

Update functional test runner to run locally with Safari, Chrome, and Firefox.

Example:
UA=safari npm run test:func

Also adds a demo page debug url for each failed test:

    5) should seek 3s from end and receive video ended event for HLS fMP4...
http://localhost:8000/hls.js/demo/?src=https%3A%2F%...

and a summary of asset urls failures:

Quitting browser...
Browser quit.
{
  "http://example.com/test1.m3u8": 7,
  "http://example.com/test2.m3u8": 1
}


  121 passing (10m)
  8 failing

Why is this Pull Request needed?

Legacy webdriver configuration is needed for saucelabs, but is unable to locate drivers locally on macos.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch force-pushed the test/func-test-runner branch from 31c9e9c to 1e6a201 Compare June 11, 2025 18:20
@robwalch robwalch requested a review from cjpillsbury June 11, 2025 18:20
@robwalch robwalch force-pushed the test/func-test-runner branch 3 times, most recently from bc91d47 to daed4c9 Compare June 11, 2025 22:05
@robwalch robwalch force-pushed the test/func-test-runner branch from daed4c9 to 4f0eb1f Compare June 12, 2025 00:13
@robwalch robwalch marked this pull request as ready for review June 12, 2025 00:27
@robwalch robwalch merged commit a27418c into master Jun 12, 2025
24 of 27 checks passed
@robwalch robwalch deleted the test/func-test-runner branch June 12, 2025 01:03
@robwalch robwalch removed the request for review from cjpillsbury June 12, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant