Skip to content

fix: parse PSSH box error #7320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yajin2021
Copy link
Contributor

This PR will...

Parse PSSH box when 'version' is 1. PSSH box defines as follows:

aligned(8) class ProtectionSystemSpecificHeaderBox extends FullBox('pssh', version, flags=0)
{
    unsigned int(8)[16]                SystemID;
    if (version > 0)
    {
         unsigned int(32)              KID_count;
         {
             unsigned int(8)[16]       KID;
         } [KID_count];
    }
    unsigned int(32)                   DataSize;
    unsigned int(8)[DataSize]          Data;
}

Why is this Pull Request needed?

When version of PSSH box is 1, parsing value is an error.

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.6.6 milestone Jun 16, 2025
@robwalch robwalch merged commit d67dde1 into video-dev:master Jun 16, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants