Skip to content

V2: Rename import path #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 23, 2019
Merged

V2: Rename import path #241

merged 4 commits into from
Aug 23, 2019

Conversation

fsouza
Copy link
Collaborator

@fsouza fsouza commented Jul 26, 2019

BREAK ALL THE THINGS!

See #239.

@fsouza fsouza force-pushed the v2 branch 3 times, most recently from 6ab1771 to f09053a Compare July 27, 2019 03:04
@codecov-io
Copy link

codecov-io commented Jul 27, 2019 •
edited
Loading

Codecov Report

Merging #241 into master will decrease coverage by 0.64%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #241      +/-   ##
==========================================
- Coverage   78.36%   77.72%   -0.65%     
==========================================
  Files          31       30       -1     
  Lines        3310     3039     -271     
==========================================
- Hits         2594     2362     -232     
+ Misses        446      421      -25     
+ Partials      270      256      -14
Impacted Files Coverage Δ
provider/provider.go 89.18% <ø> (ø) ⬆️
service/presetmap.go 82.14% <ø> (ø) ⬆️
service/presetmap_params.go 89.28% <ø> (ø) ⬆️
service/transcode_params.go 70% <ø> (ø) ⬆️
db/dbtest/fake_db.go 98.27% <ø> (ø) ⬆️
provider/mediaconvert/mediaconvert.go 79.74% <ø> (ø) ⬆️
swagger/handler.go 100% <ø> (ø) ⬆️
service/transcode_responses.go 100% <ø> (ø) ⬆️
db/redis/localpreset.go 80.55% <ø> (ø) ⬆️
service/transcode.go 73.68% <ø> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecae75a...6436075. Read the comment docs.

@fsouza fsouza force-pushed the v2 branch 3 times, most recently from c09ecad to dd68ef6 Compare August 2, 2019 15:40
zsiec
zsiec approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@zsiec zsiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fsouza fsouza marked this pull request as ready for review August 22, 2019 15:05
@fsouza fsouza merged commit b883179 into master Aug 23, 2019
@fsouza fsouza deleted the v2 branch August 23, 2019 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsiec zsiec zsiec approved these changes

@flavioribeiro flavioribeiro Awaiting requested review from flavioribeiro

@scentless-apprentice scentless-apprentice Awaiting requested review from scentless-apprentice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fsouza @codecov-io @zsiec