Skip to content

[BUG] Scrolling Issue with iloc in Subset App #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Minku-Koo opened this issue Jan 29, 2024 · 1 comment
Closed

[BUG] Scrolling Issue with iloc in Subset App #256

Minku-Koo opened this issue Jan 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Minku-Koo
Copy link
Contributor

Hi there,

To Reproduce
Steps to reproduce the behavior:

  1. Start the Subset app.
  2. Row subset side.
  3. Choose iloc for row selection.
  4. Scroll down to view additional rows.
  5. Observe the scroll behavior.

Expected behavior
what you expected to happen

Desktop (please complete the following information):

  • OS: Window11
  • Chrome

I've noticed a couple of bugs in the Subset app that need to be addressed. Here are the issues I've identified:

1. Scrolling Issue in Row Subset Creation with iloc:
When creating a row subset in the Subset app and selecting iloc, the scroll is indefinitely fixed downwards. This means users are unable to scroll upwards. This behavior disrupts the user experience and needs to be fixed.

2. Incorrect Number Generation in Scrolling with More Than 10 Rows:
In the same environment, when the number of rows exceeds 10, scrolling down results in the incorrect generation of new numbers. This inconsistency affects the accuracy of data presentation and should be rectified.

I've resolved these two bugs locally and would like to submit a pull request to address them. Could you please review my changes and let me know if they meet your expectations?

Thank you for your attention to these issues.

@Minku-Koo Minku-Koo added the bug Something isn't working label Jan 29, 2024
@minjk-bl
Copy link
Collaborator

Hi @Minku-Koo 😄

Thank you for finding the bug.
I've just checked the bug you mentioned, and it seems there is indeed an issue.
We'll incorporate the PR you submitted in the next version and make the necessary updates!

Thank you for your ongoing interest and contributions! 👍🏼

minjk-bl added a commit that referenced this issue May 7, 2024
Fixed #256 : [BUG] Scrolling Issue with iloc in Subset App
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants