Skip to content

Use newer version of Cocopa #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2024
Merged

Use newer version of Cocopa #39

merged 2 commits into from
Oct 13, 2024

Conversation

stigpo
Copy link

@stigpo stigpo commented Oct 3, 2024

Use a version of cocopa that supports more advanced inclusion parameters used in RP Pico SDK.

@stigpo
Use newer version of Cocopa
b6b825b 
Use a version of cocopa that supports more advanced inclusion parameters used in RP Pico SDK.
lersi
lersi approved these changes Oct 3, 2024
View reviewed changes
Copy link

@lersi lersi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine, sadly the original cocopa repo seems to be unmaintained

@lersi lersi linked an issue Oct 3, 2024 that may be closed by this pull request
Use newer Cocopa to handle more advanced GCC inclusion parameters #38
Closed
@lersi
Copy link

lersi commented Oct 3, 2024

The build fails because Microsoft archived their repository and deleted all releases, some of the build process is relaying on these binaries. So all merge requests are blocked until I resolve this issue.

@lersi lersi added the enhancement New feature or request label Oct 3, 2024
@stigpo
Copy link
Author

stigpo commented Oct 3, 2024

The build fails because Microsoft archived their repository and deleted all releases, some of the build process is relaying on these binaries. So all merge requests are blocked until I resolve this issue.

Yes, I noticed. I don't know what the old string_decoder did and the repo seems to have some other issues too, but to get something to compile, I just dropped string_decoder and upgraded nan. This let me build it on Windows and produced a valid cocopa.js in out that I could "hot swap" into the marketplace installed version, so now I have a working extension with support for the inclusions used in Pico.

@lersi
Copy link

lersi commented Oct 12, 2024

Sorry for the long delay, had busy personal life.
I have fixed the build system and dependencies, please pull the latest changes from main

@lersi
Copy link

lersi commented Oct 13, 2024

Nice, thank you very much!

@lersi lersi merged commit bbb99eb into vscode-arduino:main Oct 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lersi lersi lersi approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use newer Cocopa to handle more advanced GCC inclusion parameters
2 participants
@stigpo @lersi