Skip to content

#159 Vue-multiselect doesn't work properly with objects #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2017
Merged

#159 Vue-multiselect doesn't work properly with objects #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/fields/optional/fieldVueMultiSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,11 @@
}
},
customLabel(){
if (typeof this.schema.selectOptions !== "undefined" && typeof this.schema.selectOptions.customLabel !== "undefined" && this.schema.selectOptions.customLabel === "function") {
if (typeof this.schema.selectOptions !== "undefined" && typeof this.schema.selectOptions.customLabel !== "undefined" && typeof this.schema.selectOptions.customLabel === "function") {
return this.schema.selectOptions.customLabel;
} else {
return function(currentLabel){return currentLabel;};
//this will let the multiselect library use the default behavior if customLabel is not specified
return undefined;
}
}
},
Expand Down
62 changes: 62 additions & 0 deletions test/unit/specs/fields/fieldVueMultiSelect.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,5 +100,67 @@ describe("fieldVueMultiSelect.vue", function() {
});

});

describe("with objects", () => {
const option = {
name: "Vue.js",
language: "JavaScript"
};
let schema = {...schema};
let model = {
city: [option]
};
schema.values = [
{
name: "Vue.js",
language: "JavaScript"
},
{
name: "Rails",
language: "Ruby"
},
{
name: "Sinatra",
language: "Ruby"
}];
schema.selectOptions = {};
before(() => {
createField(this, schema, model, false);
input = el.querySelector(".multiselect");
});

it("model value should work with objects", (done) => {
schema.selectOptions = {label: "name", trackBy: "name"};
vm.$nextTick(() => {
expect(model.city.length).to.be.equal(1);
expect(model.city[0]).to.be.eql(schema.values[0]);
done();
});
});

it("options should contain only text specified in label", (done) => {
schema.selectOptions = {label: "language", trackBy: "language"};
vm.$nextTick(() => {
let options = input.querySelectorAll("li .multiselect__option");
expect(options[0].querySelector("span").textContent).to.be.equal("JavaScript");
done();
});
});

it("options should contain custom text specified in customLabel", (done) => {
schema.selectOptions = {
label: "name",
trackBy: "name",
customLabel: ({name, language}) => {
return `${name}-${language}`;
}
};
vm.$nextTick(() => {
let options = input.querySelectorAll("li .multiselect__option");
expect(options[0].querySelector("span").textContent).to.be.equal("Vue.js-JavaScript");
done();
});
});
});
});
});