Skip to content

Conversation

zhiyuanzmj
Copy link
Member

No description provided.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2023

⚠️ No Changeset found

Latest commit: 69d823a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some comments left for you 🏓

Comment on lines 144 to 145
"@vue-macros/volar/export-expose", // Or "@vue-macros/volar/export-props"
"@vue-macros/volar/export-render",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These three are mutually exclusive. We need to point this out in more detailedly.

@@ -141,7 +141,8 @@ npm i -D @vue-macros/volar
"@vue-macros/volar/define-props-refs",
"@vue-macros/volar/short-vmodel",
"@vue-macros/volar/define-slots",
"@vue-macros/volar/export-props",
"@vue-macros/volar/export-expose", // 或 "@vue-macros/volar/export-props",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@sxzz sxzz changed the title docs: add volar usage docs: add volar usage & translate Aug 26, 2023
@sxzz sxzz merged commit 7a675e4 into vue-macros:main Aug 26, 2023
@Gehbt Gehbt mentioned this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants