Skip to content

feat(define-prop): migrate defineProp from @vue/language-tools #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 3, 2025
Merged

feat(define-prop): migrate defineProp from @vue/language-tools #961

merged 10 commits into from
Jul 3, 2025

Conversation

zhiyuanzmj
Copy link
Member

Description

vuejs/language-tools#5415 have been removed defineProp, so migrate to vue-macros.

experimentalDefinePropProposal is removed use edition instead.

VueMacros({
  defineProp: {
    /**
     * 'kevinEdition' | 'johnsonEdition'
     * @default 'kevinEdition'
     */
    edition: 'kevinEdition',
  },
})

Linked Issues

Additional context

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel Vercel
Copy link

vercel bot commented Jun 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
vue-macros ✅ Ready (Inspect) Visit Preview Jul 3, 2025 10:20am

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 10, 2025
@zhiyuanzmj zhiyuanzmj marked this pull request as draft June 10, 2025 14:51
@zhiyuanzmj zhiyuanzmj changed the title feat(define-prop): migrate defineProp from language-tools feat(define-prop): migrate defineProp from @vue/language-tools Jun 10, 2025
@dosubot dosubot bot added the enhancement New feature or request label Jun 10, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 15, 2025 •
edited
Loading

Open in StackBlitz

@vue-macros/api

npm i https://pkg.pr.new/@vue-macros/api@961

@vue-macros/astro

npm i https://pkg.pr.new/@vue-macros/astro@961

@vue-macros/better-define

npm i https://pkg.pr.new/@vue-macros/better-define@961

@vue-macros/boolean-prop

npm i https://pkg.pr.new/@vue-macros/boolean-prop@961

@vue-macros/chain-call

npm i https://pkg.pr.new/@vue-macros/chain-call@961

@vue-macros/common

npm i https://pkg.pr.new/@vue-macros/common@961

@vue-macros/config

npm i https://pkg.pr.new/@vue-macros/config@961

@vue-macros/define-emit

npm i https://pkg.pr.new/@vue-macros/define-emit@961

@vue-macros/define-models

npm i https://pkg.pr.new/@vue-macros/define-models@961

unplugin-vue-define-options

npm i https://pkg.pr.new/unplugin-vue-define-options@961

@vue-macros/define-prop

npm i https://pkg.pr.new/@vue-macros/define-prop@961

@vue-macros/define-props

npm i https://pkg.pr.new/@vue-macros/define-props@961

@vue-macros/define-props-refs

npm i https://pkg.pr.new/@vue-macros/define-props-refs@961

@vue-macros/define-render

npm i https://pkg.pr.new/@vue-macros/define-render@961

@vue-macros/define-slots

npm i https://pkg.pr.new/@vue-macros/define-slots@961

@vue-macros/define-stylex

npm i https://pkg.pr.new/@vue-macros/define-stylex@961

@vue-macros/devtools

npm i https://pkg.pr.new/@vue-macros/devtools@961

@vue-macros/eslint-config

npm i https://pkg.pr.new/@vue-macros/eslint-config@961

@vue-macros/export-expose

npm i https://pkg.pr.new/@vue-macros/export-expose@961

@vue-macros/export-props

npm i https://pkg.pr.new/@vue-macros/export-props@961

@vue-macros/export-render

npm i https://pkg.pr.new/@vue-macros/export-render@961

@vue-macros/hoist-static

npm i https://pkg.pr.new/@vue-macros/hoist-static@961

@vue-macros/jsx-directive

npm i https://pkg.pr.new/@vue-macros/jsx-directive@961

vue-macros

npm i https://pkg.pr.new/vue-macros@961

@vue-macros/named-template

npm i https://pkg.pr.new/@vue-macros/named-template@961

@vue-macros/nuxt

npm i https://pkg.pr.new/@vue-macros/nuxt@961

@vue-macros/reactivity-transform

npm i https://pkg.pr.new/@vue-macros/reactivity-transform@961

@vue-macros/script-lang

npm i https://pkg.pr.new/@vue-macros/script-lang@961

@vue-macros/setup-block

npm i https://pkg.pr.new/@vue-macros/setup-block@961

@vue-macros/setup-component

npm i https://pkg.pr.new/@vue-macros/setup-component@961

@vue-macros/setup-sfc

npm i https://pkg.pr.new/@vue-macros/setup-sfc@961

@vue-macros/short-bind

npm i https://pkg.pr.new/@vue-macros/short-bind@961

@vue-macros/short-emits

npm i https://pkg.pr.new/@vue-macros/short-emits@961

@vue-macros/short-vmodel

npm i https://pkg.pr.new/@vue-macros/short-vmodel@961

@vue-macros/test-utils

npm i https://pkg.pr.new/@vue-macros/test-utils@961

@vue-macros/volar

npm i https://pkg.pr.new/@vue-macros/volar@961

commit: bd7f586

@zhiyuanzmj
Copy link
Member Author

Waiting twoslash to upgraded.
twoslashes/twoslash#71

@zhiyuanzmj zhiyuanzmj marked this pull request as ready for review July 3, 2025 08:38
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jul 3, 2025
@zhiyuanzmj
Copy link
Member Author

Done, Ready for merge.

@sxzz sxzz merged commit d2b253b into main Jul 3, 2025
11 checks passed
@sxzz sxzz deleted the move-define-prop branch July 3, 2025 15:55
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhiyuanzmj @sxzz