Skip to content

Lazy load the GitHub badges #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 24, 2016
Merged

Lazy load the GitHub badges #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2e4fb25
Lazyload the GitHub badges
Jun 24, 2016
d9a7017
Move hash handler to mounted()
Jun 24, 2016
f5c0ad3
Minor typo
Jun 24, 2016
071f4a5
Force lazyloading image revalidation
Jun 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion app/site/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,15 @@

<script>
import _ from 'lodash'
import Blazy from 'blazy'
import { event } from './utils'
import group from './components/Group.vue'
import explore from './components/Explore.vue'
import mainHeader from './components/Header.vue'
import mainFooter from './components/Footer.vue'

let blazy = null

export default {
components: { group, explore, mainHeader, mainFooter },

Expand All @@ -63,8 +66,15 @@ export default {

this.debounceFilter()
})
},

mounted() {
// Register lazyloading for the GitHub badges
blazy = new Blazy({
container: '.right'
})

// Also, upon page load, tf there's a hash, we filter the awesome list
// Also, upon page load, if there's a hash, we filter the awesome list
// right away.
if (window.location.hash) {
this.q = /^#(.*)/.exec(window.location.hash)[1].toLowerCase()
Expand Down Expand Up @@ -92,6 +102,11 @@ export default {
}

this.groups = this.filter(_.cloneDeep(window.data), q)

// Force Blazy to revalidate the images for lazy loading
this.$nextTick(() => {
blazy.revalidate()
})
}, 100),

/**
Expand Down
4 changes: 3 additions & 1 deletion app/site/src/components/Item.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@
<template v-else>{{ item.author.name }}</template>
</span>
<a v-if="githubBadgeUrl" :href="item.url" class="github-badge">
<img :src="githubBadgeUrl">
<img class="b-lazy"
src="data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw=="
:data-src="githubBadgeUrl">
</a>
</h1>
<div class="thin" v-if="item.description" v-html="item.description"></div>
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"babel-core": "^6.0.0",
"babel-loader": "^6.0.0",
"babel-preset-es2015": "^6.0.0",
"blazy": "^1.6.2",
"chalk": "^1.1.3",
"copy-webpack-plugin": "^3.0.1",
"cross-env": "^1.0.6",
Expand Down