fix: handle nullish dynamic event name with event modifiers #13060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
| eventName: string, | ||
| modifierPostfix: string, | ||
| ): string { | ||
| if (eventName != null && eventName !== '') return eventName + modifierPostfix |
There was a problem hiding this comment.
Are there any circumstances where eventName would be null or undefined? From the test cases it seems like _toHandlerKey would have already converted those to empty strings.
There was a problem hiding this comment.
Thanks for your review. Sorry I didn't notice the review right away. The eventName can only be a string. I will modify it.
WalkthroughA new runtime helper and utility function were introduced to handle dynamic event names with modifiers in Vue's compiler and runtime. The transformation logic for dynamic event keys with modifiers was updated, and corresponding tests were added to verify correct handling, especially when the event name is nullish or empty. Changes
Sequence Diagram(s)sequenceDiagram
participant Template
participant Compiler
participant RuntimeHelpers
participant Runtime
Template->>Compiler: Uses @[eventName].modifier="handler"
Compiler->>RuntimeHelpers: Calls V_ON_WITH_DYNAMIC_EVENT_MODIFIERS(eventName, modifierPostfix)
RuntimeHelpers->>Runtime: Registers withDynamicEventModifiers helper
Runtime->>Runtime: withDynamicEventModifiers(eventName, modifierPostfix)
Runtime-->>Template: Returns correct event attribute or empty string
Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes found. Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
4c8493b to
d2d2e3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #13056
Summary by CodeRabbit
New Features
Tests