chore(types): remove global declared script setup helpers #13631

KazariEX · 2025-07-14T18:23:50Z

We generate imports for these helpers in the correct setup scope in language tools, so this file is no longer needed, and it also caused completion for these helpers to appear in non-setup scripts incorrectly.

Summary by CodeRabbit

Chores
- Removed global TypeScript declarations for several script setup helper functions, including defineProps, defineEmits, defineExpose, defineOptions, defineSlots, defineModel, and withDefaults. This may affect global type availability in some development environments.

coderabbitai · 2025-07-14T18:23:56Z

Walkthrough

A TypeScript declaration file that globally declared several script setup helper functions and their type aliases was deleted. This removal eliminates the global type definitions for helpers such as defineProps, defineEmits, defineExpose, and others from the runtime core package.

Changes

File(s)	Change Summary
packages/runtime-core/types/scriptSetupHelpers.d.ts	Deleted TypeScript declaration file for global script setup helper functions and type aliases.

Poem

A file once lived, with helpers so neat,
Declaring the types for each global treat.
Now it has vanished, its duties complete,
The code hops along—no more global cheat!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 347ef1d and e329206.

📒 Files selected for processing (1)

packages/runtime-core/types/scriptSetupHelpers.d.ts (0 hunks)

💤 Files with no reviewable changes (1)

packages/runtime-core/types/scriptSetupHelpers.d.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: Redirect rules
GitHub Check: Header rules
GitHub Check: Pages changed

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-07-14T18:24:44Z

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	101 kB	38.4 kB	34.5 kB
vue.global.prod.js	159 kB	58.5 kB	52.1 kB

Usages

Name	Size	Gzip	Brotli
createApp (CAPI only)	46.5 kB	18.2 kB	16.7 kB
createApp	54.5 kB	21.2 kB	19.4 kB
createSSRApp	58.7 kB	22.9 kB	20.9 kB
defineCustomElement	59.5 kB	22.8 kB	20.8 kB
overall	68.5 kB	26.4 kB	24 kB

pkg-pr-new · 2025-07-14T18:24:56Z

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13631

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13631

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13631

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13631

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13631

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13631

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13631

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13631

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13631

vue

npm i https://pkg.pr.new/vue@13631

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13631

commit: e329206

edison1105 · 2025-07-15T01:06:20Z

/ecosystem-ci run

vue-bot · 2025-07-15T01:13:24Z

📝 Ran ecosystem CI: Open

suite	result	latest scheduled
primevue	✅ success	✅ success
language-tools	✅ success	✅ success
quasar	✅ success	✅ success
pinia	✅ success	✅ success
test-utils	✅ success	✅ success
vue-i18n	✅ success	✅ success
vue-macros	❌ failure	❌ failure
vitepress	✅ success	✅ success
vite-plugin-vue	✅ success	✅ success
radix-vue	✅ success	✅ success
router	✅ success	✅ success
vueuse	✅ success	✅ success
nuxt	✅ success	✅ success
vant	✅ success	❌ failure
vuetify	✅ success	✅ success
vue-simple-compiler	✅ success	✅ success

edison1105 · 2025-07-15T02:46:13Z

vue-macros uses these types
https://github.com/vuejs/ecosystem-ci/actions/runs/16281500109/job/45971914565

zhiyuanzmj · 2025-07-15T03:01:03Z

I can add those global macros types for vue-macros

fix(runtime-core): remove global declared script setup helpers

e329206

edison1105 changed the title ~~fix(runtime-core): remove global declared script setup helpers~~ chore(types): remove global declared script setup helpers Jul 16, 2025

edison1105 added scope: types ready for review This PR requires more reviews labels Jul 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore(types): remove global declared script setup helpers #13631

chore(types): remove global declared script setup helpers #13631

KazariEX commented Jul 14, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 14, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Jul 14, 2025

Uh oh!

pkg-pr-new bot commented Jul 14, 2025

Uh oh!

edison1105 commented Jul 15, 2025

Uh oh!

vue-bot commented Jul 15, 2025

Uh oh!

edison1105 commented Jul 15, 2025

Uh oh!

zhiyuanzmj commented Jul 15, 2025

Uh oh!

Uh oh!

Uh oh!

chore(types): remove global declared script setup helpers #13631

Are you sure you want to change the base?

chore(types): remove global declared script setup helpers #13631

Conversation

KazariEX commented Jul 14, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jul 14, 2025

Size Report

Bundles

Usages

Uh oh!

pkg-pr-new bot commented Jul 14, 2025

Uh oh!

edison1105 commented Jul 15, 2025

Uh oh!

vue-bot commented Jul 15, 2025

Uh oh!

edison1105 commented Jul 15, 2025

Uh oh!

zhiyuanzmj commented Jul 15, 2025

Uh oh!

Uh oh!

KazariEX commented Jul 14, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 14, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)