chore(sfc-playground): import vaporInteropPlugin only if Vapor mode is supported #13645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes update the "@vue/repl" dependency version in the SFC Playground's package.json and modify App.vue to conditionally enable the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App.vue
participant REPL
User->>App.vue: Change Vue version
App.vue->>App.vue: Parse version, set isVaporSupported
App.vue->>REPL: Reload REPL if version changed
App.vue->>REPL: Pass previewOptions (with or without vaporInteropPlugin)
REPL-->>User: Render preview with correct options
Assessment against linked issues
Possibly related PRs
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages-private/sfc-playground/src/App.vue (1)
119-130: Improve version parsing robustness.The version parsing logic works correctly for the expected format, but consider adding error handling for malformed version strings.
- const [major, minor] = (version || store.compiler.version) - .split('.') - .map((v: string) => parseInt(v, 10)) + const versionString = version || store.compiler.version + const parts = versionString.split('.') + const major = parseInt(parts[0], 10) || 0 + const minor = parseInt(parts[1], 10) || 0 + + if (isNaN(major) || isNaN(minor)) { + console.warn(`Invalid version format: ${versionString}`) + isVaporSupported.value = false + return + }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
packages-private/sfc-playground/package.json(1 hunks)packages-private/sfc-playground/src/App.vue(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules
- GitHub Check: Header rules
- GitHub Check: Pages changed
🔇 Additional comments (4)
packages-private/sfc-playground/package.json (1)
16-16: Dependency update approved:@vue/repl@^4.6.2is available with no known security issues.Version 4.6.2 is published on npm, and our audit did not surface any advisories for this package. You can safely proceed with the update.
packages-private/sfc-playground/src/App.vue (3)
5-5: LGTM: Import addition is correct.The
watchimport is properly added to support the new version watching functionality.
132-145: LGTM: Preview options logic is well-implemented.The conditional plugin import and usage is correctly implemented:
- Conditionally imports
vaporInteropPluginbased on Vue version support- Properly applies the plugin to the app when supported
- Maintains backward compatibility with existing custom formatter logic
176-176: LGTM: Template change is correct.The change from inline options to the computed
previewOptionsproperty enables dynamic plugin configuration based on Vue version.
Comment on lines
13
to
15
| "vite": "catalog:" | ||
| }, | ||
| "dependencies": { |
|
Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #13622
Summary by CodeRabbit
New Features
Chores