Skip to content

refactor(compiler-vapor): generate unique variable to prevent collisions with user variables #13822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: minor
Choose a base branch
from
Open

refactor(compiler-vapor): generate unique variable to prevent collisions with user variables #13822

wants to merge 7 commits into from
+451 −139

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Aug 29, 2025 •
edited
Loading

this PR includes #13821

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Aug 29, 2025 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/refactor/compiler-vapor-codegen
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 29, 2025 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84 kB 29.8 kB 26.3 kB
runtime-dom.global.prod.js 104 kB 39.1 kB 35.3 kB
vue.global.prod.js 162 kB 59.3 kB 52.9 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB 18.4 kB 16.9 kB
createApp 56 kB 21.6 kB 19.7 kB
createApp + vaporInteropPlugin 68.6 kB 25.9 kB 23.6 kB
createVaporApp 20.9 kB 8.26 kB 7.57 kB
createSSRApp 60.3 kB 23.3 kB 21.3 kB
defineCustomElement 61 kB 23.1 kB 21.1 kB
overall 70.5 kB 26.8 kB 24.4 kB

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 29, 2025 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13822

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13822

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13822

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13822

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13822

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13822

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13822

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13822

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13822

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13822

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13822

vue

npm i https://pkg.pr.new/vue@13822

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13822

commit: 180308c

@netlify Netlify
Copy link

netlify bot commented Aug 29, 2025 •
edited
Loading

❌ Deploy Preview for vue-sfc-playground failed. Why did it fail? →

Name Link
🔨 Latest commit e7ac4d3
🔍 Latest deploy log https://app.netlify.com/projects/vue-sfc-playground/deploys/68b79e086acb390008b048bf

@edison1105 edison1105 force-pushed the edison/refactor/compiler-vapor-codegen branch from 91aeda6 to 9adfd60 Compare August 29, 2025 06:53
@edison1105 edison1105 added version: minor scope: vapor related to vapor mode labels Aug 29, 2025
alex-snezhko
alex-snezhko reviewed Sep 2, 2025
View reviewed changes
packages/compiler-vapor/src/generate.ts Outdated
genVarName(prefix: string, baseNum: number): string {
let num = baseNum
let name = `${prefix}${num}`
while (this.bindingNames.has(name) || this.seenVarNames.has(name)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small optimization could be to analyze the bindingMetadata in the constructor ahead of time and create a mapping for what the next free name/number is; i.e. if bindingMetadata has t0, t1, t2, and t4 then this mapping could be built like { 0 => 3, 1 => 3, 2 => 3, 4 => 5 } and it can be looked up for constant-time instead of potentially linear time complexity; likewise for the increaseId function

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see 7eb3192

Please feel free to review.

@edison1105 edison1105 changed the title refactor(compiler-vapor): add unique variable generation to avoid binding conflicts refactor(compiler-vapor): generate unique variable to prevent collisions with user variables Sep 3, 2025
@edison1105 edison1105 mentioned this pull request Sep 3, 2025
Closed
alex-snezhko
alex-snezhko reviewed Sep 3, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@alex-snezhko alex-snezhko alex-snezhko left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
scope: vapor related to vapor mode version: minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edison1105 @alex-snezhko