Skip to content

fix(runtime-vapor): setting innerHTML should go through trusted types #13825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: minor
Choose a base branch
from
Open

fix(runtime-vapor): setting innerHTML should go through trusted types #13825

wants to merge 1 commit into from
+6 −1

Conversation

edison1105
Copy link
Member

No description provided.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Aug 29, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbit review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/fix/trustedHtml
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@edison1105 edison1105 added version: minor scope: vapor related to vapor mode labels Aug 29, 2025
@edison1105 edison1105 moved this to Vapor in Next Minor Aug 29, 2025
@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84 kB 29.8 kB 26.3 kB
runtime-dom.global.prod.js 104 kB 39.1 kB 35.3 kB
vue.global.prod.js 162 kB 59.3 kB 52.9 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB 18.4 kB 16.9 kB
createApp 56 kB 21.6 kB 19.7 kB
createApp + vaporInteropPlugin 68.6 kB (+4 B) 25.9 kB (+3 B) 23.6 kB (+39 B)
createVaporApp 21 kB (+110 B) 8.33 kB (+69 B) 7.62 kB (+46 B)
createSSRApp 60.3 kB 23.3 kB 21.3 kB
defineCustomElement 61 kB 23.1 kB 21.1 kB
overall 70.5 kB 26.8 kB 24.4 kB

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 29, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13825

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13825

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13825

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13825

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13825

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13825

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13825

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13825

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13825

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13825

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13825

vue

npm i https://pkg.pr.new/vue@13825

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13825

commit: 9bf6fa9

@netlify Netlify
Copy link

netlify bot commented Aug 29, 2025

❌ Deploy Preview for vue-sfc-playground failed. Why did it fail? →

Name Link
🔨 Latest commit 9bf6fa9
🔍 Latest deploy log https://app.netlify.com/projects/vue-sfc-playground/deploys/68b1629b2b46900008e9467c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: vapor related to vapor mode version: minor
Projects
Next Minor
Status: Vapor
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@edison1105