feat: drop .vue shim and recommend typescript vue plugin by default #26
+16
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a plugin for "TypeScript and JavaScript Language Features", so once the latter is disabled, it will no longer work.
7 tasks
kkeisuke
added a commit
to kkeisuke/plantuml-editor2
that referenced
this pull request
Jan 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussions with @johnsoncodehk and @xiaoxiangmoe, we concluded that it makes more sense for most users to start with the TypeScript Vue Plugin instead of the
.vueshim.Take Over Mode is more performant and we would like to recommend it, but turning it on in VSCode takes too many steps. So I chose to only mention it in the README, so that more senior developers can know more about it.