Update detector.js #240
Merged
Update detector.js #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added findVueRootNode method to avoid prototype.js error vuejs#171
bartlomieju
reviewed
Jan 23, 2017
shells/chrome/src/detector.js
Outdated
| @@ -5,9 +5,15 @@ window.addEventListener('message', e => { | |||
| }) | |||
|
|
|||
| function detect (win) { | |||
| function findVueRootNode (array, callback) { | |||
| for (let i = 0; i < array.length;i++) { | |||
| console.log(array[i]) | |||
There was a problem hiding this comment.
I guess it should not be here
There was a problem hiding this comment.
oh, totally, it's from my local test setup O_o
removed the 'console.log' line
|
is there any more action needed for this change? |
|
Sorry, I forgot about this. I'll test it and merge this afternoon |
yyx990803
requested changes
Feb 11, 2017
shells/chrome/src/detector.js
Outdated
| @@ -5,9 +5,14 @@ window.addEventListener('message', e => { | |||
| }) | |||
|
|
|||
| function detect (win) { | |||
| function findVueRootNode (array, callback) { | |||
| for (let i = 0; i < array.length;i++) { | |||
| if (Function.prototype.call(array[i], callback)) return array[i] | |||
There was a problem hiding this comment.
Why Function.prototype.call here?
shells/chrome/src/detector.js
Outdated
| @@ -5,9 +5,14 @@ window.addEventListener('message', e => { | |||
| }) | |||
|
|
|||
| function detect (win) { | |||
| function findVueRootNode (array, callback) { | |||
| for (let i = 0; i < array.length;i++) { | |||
There was a problem hiding this comment.
space after second semicolon please :P
fix linting
use .call directly rather than prototype
|
fixed requested changes |
yyx990803
requested changes
Feb 13, 2017
shells/chrome/src/detector.js
Outdated
| @@ -5,9 +5,14 @@ window.addEventListener('message', e => { | |||
| }) | |||
|
|
|||
| function detect (win) { | |||
| function findVueRootNode (array, callback) { | |||
| for (let i = 0; i < array.length; i++) { | |||
| if (callback.call(array[i])) return array[i] | |||
There was a problem hiding this comment.
No need for the .call here either, just callback(array[i]) would do.
BTW The first argument to fn.call() is the this context it will be called with.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added findVueRootNode method to avoid prototype.js error
#171