Add Standalone Vue Remote Devtools App (electron shell) (#451) #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be able to pick up some tips from this: https://github.com/vuetwo/vuetron |
This was referenced Jan 4, 2018
Closed
Closed
|
@rigor789 I updated your PR on this branch https://github.com/vuejs/vue-devtools/tree/add-remote-devtools take a look. Quick instruction:
|
…ation and express serving file for client (backend)
Add connector as importable script
…ad of hardcoding localhost
michalsnik
reviewed
Jan 28, 2018
src/backend/hook.js
Outdated
| @@ -12,75 +12,77 @@ | |||
| export function installHook (window) { | |||
| let listeners = {} | |||
|
|
|||
| const hook = { | |||
| Vue: null, | |||
| if (!window.hasOwnProperty('__VUE_DEVTOOLS_GLOBAL_HOOK__')) { | |||
There was a problem hiding this comment.
Perhaps without extra indentation?
if (window.hasOwnProperty('__VUE_DEVTOOLS_GLOBAL_HOOK__')) return
michalsnik
reviewed
Jan 28, 2018
shells/dev/target-electron.html
Outdated
| <div id="app"></div> | ||
| <div id="shadow"></div> | ||
| <script src="http://localhost:8098"></script> | ||
| <script src="build/hook.js"></script> |
There was a problem hiding this comment.
Hook is not needed here, it's being loaded by above script
Akryum
approved these changes
Jan 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP for adding an electron shell and remote debugging to VueDevtools.
Discussion is at #451