Skip to content

Fix initEnv, so it doesn't crash on page refresh #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2018
Merged

Fix initEnv, so it doesn't crash on page refresh #590

merged 1 commit into from
Jan 30, 2018

Conversation

michalsnik
Copy link
Member

Redefining ownProperties on Vue.prototype causes error on page refresh, as it executes initEnv once again. I check for presence of one of the properties assigned there so it doesn't reinitiate it when already initialized.

@michalsnik michalsnik requested a review from Akryum January 30, 2018 12:39
@Akryum Akryum merged commit e682c36 into master Jan 30, 2018
@Akryum Akryum deleted the fix-electron-init branch January 30, 2018 12:44
@Akryum Akryum added this to the v4.1.3 milestone Jan 30, 2018
@Akryum
Copy link
Member

Akryum commented Jan 30, 2018

Fix #588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akryum Akryum Akryum approved these changes

Assignees
No one assigned
Labels
bug semver-patch
Projects
None yet
Milestone
v4.1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@michalsnik @Akryum