Skip to content

Conversation

michalsnik
Copy link
Member

@michalsnik michalsnik commented Feb 21, 2018

This PR addresses #597 as well as some other thing by the way, like:

  • port overriding - it turned out it was not entirely possible. I also updated documentation with necessary informations of how to do it.
  • it makes it possible to reset default port, which might be useful while debugging using ngrok proxy, where simple link proxies to proper port on localhost and thus connection URL doesn't need additional port.

By introducing above changes it also became possible to inspect staging applications if necessary, by proxying devtools middleware through ngrok. Just as with HTTPS on localhost :)

@@ -2,7 +2,7 @@ import io from 'socket.io-client'
import { initDevTools } from 'src/devtools'
import Bridge from 'src/bridge'

const port = process.env.PORT || 8098
const port = window.process.env.PORT || 8098
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this legitimate? (not a typo?)

Copy link
Member Author

@michalsnik michalsnik Feb 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, it's intended :) without window. it doesn't see the overriden PORT

@michalsnik
Copy link
Member Author

Friendly reminder @Akryum ☝️

@Akryum Akryum removed this from the v4.2.0 milestone Mar 11, 2018
@michalsnik michalsnik merged commit 4994856 into master Mar 11, 2018
@michalsnik michalsnik deleted the fix-port-and-document-https branch March 11, 2018 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants