Duplicate removal rootInstances #647
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just as [React Protals](https://reactjs.org/docs/portals.html) ,a DOM node that exists outside the DOM hierarchy of the parent component may be the same rootInstance eg. [ iview Modal/Poptip/Dropdown/... "transfer" props ](https://www.iviewui.com/components/dropdown-en#API) true to “ Whether to append the layer in body ” , Multi duplicate root instances appear in vue-devtools .
Just as [React Protals](https://reactjs.org/docs/portals.html) ,a DOM node that exists outside the DOM hierarchy of the parent component may be the same rootInstance eg. [ iview Modal/Poptip/Dropdown/... "transfer" props ](https://www.iviewui.com/components/dropdown-en#API) true to “ Whether to append the layer in body ” , Multi duplicate root instances appear in vue-devtools .
Just as [React Protals](https://reactjs.org/docs/portals.html) ,a DOM node that exists outside the DOM hierarchy of the parent component may be the same rootInstance eg. [ iview Modal/Poptip/Dropdown/... "transfer" props ](https://www.iviewui.com/components/dropdown-en#API) True to “ Whether to append the layer in body ” , Multi duplicate root instances appear in vue-devtools .
|
Fixed in #711, thanks for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just as React Protals ,a DOM node that exists outside the DOM hierarchy of the parent component may be the same rootInstance
eg.
iview Modal/Poptip/Dropdown/... "transfer" props
True to “ Whether to append the layer in body ” , Multi duplicate root instances appear in vue-devtools . #645
I think the better solution is if the same root node displays the component node, and different root nodes show another root node.