Skip to content

chore: bump eslint-plugin-vue to v9 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 8, 2022
Merged

chore: bump eslint-plugin-vue to v9 #42

merged 2 commits into from
Jun 8, 2022

Conversation

cexbrayat
Copy link
Member

@cexbrayat cexbrayat commented May 18, 2022 •
edited
Loading

eslint-plugin-vue v9 has been released and yields warnings if not used with vue-eslint-parser v9 (which is the case if you naively bump the version in a freshly created create-vue project).

See vuejs/eslint-plugin-vue#1893 for context

This PR bumps the version of both dependencies. Ideally, this should be released and used in new create-vue projects (I can open the following PRs when this one is merged and released)

ota-meshi
ota-meshi reviewed May 18, 2022
View reviewed changes
@cexbrayat cexbrayat force-pushed the chore/eslint-plugin-vue-v9 branch from 33e8700 to 2cbfb9f Compare May 18, 2022 15:56
@DrJume DrJume mentioned this pull request May 19, 2022
Closed
@Fuzzyma
Copy link

Fuzzyma commented May 24, 2022

So what is this PR waiting for?

@ivanmaxlogiudice
Copy link

+1

@vivekjoshy
Copy link

Is there a reason this isn't merged yet?

@imsfc
Copy link

imsfc commented May 31, 2022

Why haven't they merged yet?

jxjj added a commit to UMN-LATIS/Camino that referenced this pull request May 31, 2022
@jxjj
chore: prevent script setup vars from showing as usused
9110d94 
prevents vars used in `<script setup>` from being reported as unused by eslint. This can be removed once vuejs/eslint-config-typescript#42 is merged into eslint-config-typescript.
@TheSeg
Copy link

TheSeg commented Jun 1, 2022

Checking in on progress. This is preventing moving forward with now three releases of vuejs/eslint-plugin-vue

@MartinX3
Copy link

MartinX3 commented Jun 1, 2022 •
edited
Loading

I don't understand it.
There is the default dependabot to automatically create dependency bump PR's and you can create a github actions CI to automerge patch and minor version dependency jumps...

@cexbrayat
Copy link
Member Author

Please stop commenting on this issue: the maintainers of this repo will merge this as soon as they can. They all do this in their free time. You're just adding noise, and things won't go faster.

In the meantime, you can upgrade to eslint-plugin-vue v9 if you really want to. You just have to install it manually and use a resolution to force vue-eslint-parser to v9 as well.

"resolutions": {
    "//": "remove vue-eslint-parser resolution when https://github.com/vuejs/eslint-config-typescript/pull/42 is merged",
    "vue-eslint-parser": "9.0.2"
  }

@vernaillen vernaillen mentioned this pull request Jun 4, 2022
Open
16 tasks
@haoqunjiang haoqunjiang merged commit 02cd781 into vuejs:main Jun 8, 2022
@cexbrayat cexbrayat deleted the chore/eslint-plugin-vue-v9 branch June 8, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoqunjiang haoqunjiang haoqunjiang approved these changes

+1 more reviewer

@ota-meshi ota-meshi ota-meshi left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@cexbrayat @Fuzzyma @ivanmaxlogiudice @vivekjoshy @imsfc @TheSeg @MartinX3 @haoqunjiang @ota-meshi