Skip to content

Please make a new alpha release or backport a bugfix #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Amndeep7 opened this issue Jun 25, 2020 · 4 comments
Closed

Please make a new alpha release or backport a bugfix #1221

Amndeep7 opened this issue Jun 25, 2020 · 4 comments

Comments

@Amndeep7
Copy link

I'm running into the bug fixed here at

eslint-plugin-vue/lib/rules/no-unused-components.js

Lines 88 to 90 in b33c708

if (!node.value) {
return
}
where the linter tries to access a property of an object that's null in the no-unused-components rule.

Currently builds for a project of mine are failing due to the linter crashing. I validated this by manually adding the fix to the local copy of this library in my node_modules, which allowed the build to proceed as usual.

I would really appreciate it if you could either backport the fix to the 5.2.x and/or 6.2.x lines (I can make the PR if necessary) or make a new alpha release.
@Amndeep7 Amndeep7 mentioned this issue Jun 25, 2020
Closed
38 tasks
@ota-meshi
Copy link
Member

Thank you for this issue.

I will merge some PRs and release v7.0.0.alpha if I can spare time this weekend.

I can't take the time to check the behavior of each version, so I won't backport.
Thank you for your understanding.

@ota-meshi ota-meshi mentioned this issue Jun 26, 2020
Merged
@Amndeep7
Copy link
Author

Yeah, a new release is completely fine. I'll close the issue when it's out. Thank you!

@ota-meshi
Copy link
Member

I have released a new version so close this issue.

@Amndeep7
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Amndeep7 @ota-meshi