Skip to content

fix(no-deprecated-slot-attribute): no fix for dynamic components #2530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2024
Merged

fix(no-deprecated-slot-attribute): no fix for dynamic components #2530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f24c45
fix(no-deprecated-slot-attribute): handle v-for with dynamic slot
privatenumber Aug 15, 2024
f35bf94
fix(no-deprecated-slot-attribute): dont autofix dynamic component
privatenumber Aug 15, 2024
b06212d
Merge branch 'master' into slot-attribute-dynamic-component
ota-meshi Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/rules/syntaxes/utils/can-convert-to-v-slot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ module.exports = function canConvertToVSlot(element, sourceCode, tokenStore) {
const ownerElement = element.parent
if (
ownerElement.type === 'VDocumentFragment' ||
!utils.isCustomComponent(ownerElement)
!utils.isCustomComponent(ownerElement) ||
ownerElement.name === 'component'
) {
return false
}
Expand Down
13 changes: 13 additions & 0 deletions tests/lib/rules/no-deprecated-slot-attribute.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,6 +668,19 @@ tester.run('no-deprecated-slot-attribute', rule, {
</my-component>
</template>`,
errors: ['`slot` attributes are deprecated.']
},
{
code: `
<template>
<component :is="toggle ? 'my-component' : 'div'">
<div slot="named">
Passing in a named slot to a div worked with old syntax
But not with new syntax
</div>
</component>
</template>`,
output: null,
errors: ['`slot` attributes are deprecated.']
}
]
})
Loading