Skip to content

fix: fix typecheck #2707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2025
Merged

fix: fix typecheck #2707

merged 2 commits into from
Mar 6, 2025

Conversation

ntnyq
Copy link
Contributor

@ntnyq ntnyq commented Mar 6, 2025

This PR fixes typecheck of project.

FloEdelmann
FloEdelmann approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have one suggestion that makes the condition a bit easier to read and more consistent with other AST node type checks.

@FloEdelmann FloEdelmann merged commit 698f240 into vuejs:master Mar 6, 2025
7 checks passed
@FloEdelmann FloEdelmann added the meta Code style improvements, build process improvements, refactorings label Mar 6, 2025
@ntnyq ntnyq deleted the fix/tsc branch June 6, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
meta Code style improvements, build process improvements, refactorings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntnyq @FloEdelmann