Skip to content

fix(valid-define-options): Allow the use of simple constants #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 3, 2025
+20 −1
Merged

fix(valid-define-options): Allow the use of simple constants #2920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d523648
feat: Add allowVariableNamePattern to valid-define-options
Aug 29, 2025
fef5b53
Revert "feat: Add allowVariableNamePattern to valid-define-options"
FrontEndDog Sep 2, 2025
e08fe28
fix(valid-define-options): Allow the use of simple constants
FrontEndDog Sep 3, 2025
480367b
fix
FrontEndDog Sep 3, 2025
ede7315
optimize code
FrontEndDog Sep 3, 2025
a034a23
optimize code
FrontEndDog Sep 3, 2025
89a4444
Merge branch 'master' into feat/valid-define-options
FrontEndDog Sep 3, 2025
73210e7
Merge branch 'master' into feat/valid-define-options
FloEdelmann Sep 3, 2025
760f416
chore: add changeset
waynzh Sep 3, 2025
9536f05
Update changeset
FloEdelmann Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fresh-taxis-glow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'eslint-plugin-vue': minor
---

Changed `vue/valid-define-options` to allow local literal constant references
8 changes: 7 additions & 1 deletion lib/rules/valid-define-options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,13 @@ module.exports = {
(def) =>
def.type !== 'ImportBinding' &&
utils.inRange(scriptSetup.range, def.name) &&
!utils.inRange(defineOptions.range, def.name)
!utils.inRange(defineOptions.range, def.name) &&
!(
def.type === 'Variable' &&
def.parent.kind === 'const' &&
def.node.init &&
def.node.init.type === 'Literal'
)
)
) {
if (utils.withinTypeNode(node)) {
Expand Down
8 changes: 8 additions & 0 deletions tests/lib/rules/valid-define-options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,14 @@ tester.run('valid-define-options', rule, {
defineOptions(def);
</script>`
},
{
filename: 'test.vue',
code: `
<script setup>
const def = 'foo';
defineOptions({ name: def });
</script>`
}
],
invalid: [
Expand Down