🍒 We said, input and textarea elements, but it's also for select elemen… #1160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuejs#1719) * We said, input and textarea elements, but it's also for select element * Add Oxford comma
Closed
kaorun343
pushed a commit
to kaorun343/jp.vuejs.org
that referenced
this pull request
Sep 26, 2018
* Style Guide (vuejs#1160) * initial style guide prototype with examples * clarify component style scoping in 3rd-party libs * flesh out rule for complex computed properties * clarify component style scoping * flesh out self-closing components rule in style guide * flesh out style guide entry for component name casing in JS/JSX * complete draft for priority A rules * complete draft for priority B rules * style guide fixes after @KatieMFritz's review * fix code block styles, especially on style guide * fix wrong formatting for in-dom templates style rule * simplify data function detailed explanation in style guide * in style guide, add detailed explanation with example for keyed v-for * in style guide, improve explanation of order of words in component names * in style guide, link to SFC and JSX explanations * WIP * complete definitions for all style guide rules * minor language tweaks to style guide * update SG recommendation for nested component directories, courtesy of @Akryum * fix SG typo in self-closing components example * update SG component options order, tag @Akryum @posva * add category tags to rule titles * style guide round of edits and simplification * move list rendering above conditionals in SG element attribute order * add SG rule about empty lines in component/instance options * fixed missing and added commas in SG example * move style guide to its own page * make exception to multi-word component names for App in SG * add beta tag to style guide * fix typos pointed out by @phanan * clarify keyed v-for rule in SG * update when component subdirectories are worth considering in SG * add link to HTML spec in multi-word component names SG rule * updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
resolves #1132
Original:vuejs/v2.vuejs.org@ce32ecc