fix: improve code gen when using cssVars in SSR #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edison1105
commented
Apr 12, 2023
| @@ -276,6 +277,7 @@ async function doCompileTemplate( | |||
| isTS: boolean | |||
| ) { | |||
| const templateResult = store.compiler.compileTemplate({ | |||
| isProd: false, | |||
| ...store.options?.template, | |||
There was a problem hiding this comment.
idProd may be defined in store.options?.template
edison1105
commented
Apr 12, 2023
| // script ssr needs to be performed if : | ||
| // 1.using <script setup> where the render fn is inlined. | ||
| // 2.using cssVars, as it do not need to be injected during SSR. | ||
| if (descriptor.scriptSetup || descriptor.cssVars.length > 0) { |
There was a problem hiding this comment.
If cssVars is used,clientScript is not the same as ssrScript because we do not inject useCssVars into ssr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to vuejs/core#6979
without <script setup>
before: see
after:
