Skip to content

Add in cookbook template #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2017
Merged

Add in cookbook template #1268

merged 2 commits into from
Nov 10, 2017

Conversation

sdras
Copy link
Member

@sdras sdras commented Nov 9, 2017

Creating a template for common use and guidelines for contributing to The Cookbook. Most of this is a standardization of the Adding Instance Properties example from @chrisvfritz.

Some things to note, entirely up for debate:

  • I detailed that some sections are required, and some are optional. I think smaller examples will not need as much detail but more advanced concepts do.
  • The order is set to 1000 to make it last, but I'm unfamiliar with this ordering schema so I may need guidance there.

@sdras sdras self-assigned this Nov 9, 2017
@sdras sdras requested a review from chrisvfritz November 9, 2017 23:25
Copy link
Contributor

@chrisvfritz chrisvfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic! 🎉 I left a couple small notes, but I think this will give us a great base moving forward. I don't expect that this will serve every possible recipe, but I think that would be impossible. We can continue adapting it and perhaps eventually split it out into several possible templates as the cookbook evolves.

One other note is that we may want to delay the invitation for non-members to contribute recipes for now. Or as you suggested in the Slack, request that they open an issue to discuss it before starting a cookbook recipe. (I know, I'm fickle and changed my mind as I thought about it more. 😅)


_optional, except when the section above is provided_

This section is required when you've provided the section above about avoidance. It's important to explore other methods so that people told that something is an antipattern in certain situations are not left high and dry. In doing so, consider that the web is a big tent and that many people have different codebase structures and are solving different goals. Is the app large or small? Are they integrating Vue into an existing project, or are they building from scratch? Are their users only trying to achieve one goal or many? Is there a lot of asyncronous data? All of these concerns will impact alternative implementations. A good cookbook recipe gives developers this context.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "left high and dry" might be difficult for non-native speakers to understand. How about "left wondering"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! I need to get in this mindset of internationalization

- Articulate the problem in a sentence or two.
- Explain the simplest possible solution in a sentence or two.
- Show a small code sample.
- Explain what this accomplishes in a sentence.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, sometimes I like to include a code example demonstrating the problem before I go into the solution.

Also, maybe these should be numbered to imply that they are all required and should generally be followed in order.

Copy link
Member Author

@sdras sdras Nov 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, what if the flow of how to explain that code in particular doesn't work that way? Perhaps it's possible to do an ol and say that the order is "strongly suggested, but not imperative". Actually imperative has other meanings in code haha, so maybe... "vital".

@sdras
Copy link
Member Author

sdras commented Nov 10, 2017

I've updated the PR with some of the suggestions above, as well as some additional improvements:

  • change the wording of the english slang
  • update the uls to ols, but with a statement that the ordering is strongly suggested but not required (flexibility for times when the flow makes more sense another way)
  • put in a requirement for filing an issue, under a tag I just created called cookbook idea
  • small edits for clarity

Happy to update further! Let me know what you think.

Copy link
Contributor

@chrisvfritz chrisvfritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! 🚀 💥 😸

@chrisvfritz chrisvfritz merged commit 2fc6cfa into vuejs:master Nov 10, 2017
@sdras sdras deleted the cookbook-template branch November 10, 2017 13:24
kazupon pushed a commit to kazupon/vuejs.org that referenced this pull request Nov 24, 2017
* update sponsor link

* update sponsor image

* Add in cookbook template (vuejs#1268)

* Add in cookbook template

* update cookbook template based on review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants