Skip to content

minor grammar fix #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2016
Merged

minor grammar fix #324

merged 2 commits into from
Jun 22, 2016

Conversation

kas
Copy link
Contributor

@kas kas commented Jun 20, 2016

Hi Evan,

Thank you for creating the framework! I have been using it recently and it is amazing compared to some of the other more clunky front end frameworks available.

I was reading the guide and saw a sentence that I thought should be reworded. I made the minor change in this commit.

I appreciate you reviewing this pull request!

@chrisvfritz
Copy link
Contributor

Thanks for the contribution @kas! Unfortunately, I think this might be a bit more than a grammar fix. To me, it changes the meaning with the:

  • removal almost to make an even bolder claim
  • addition of more to possibly imply that Vue devs are more productive than Angular devs, which may be the case but is probably not a productive poitn to make here

If you update to You can learn almost everything about it quickly and become productive or You can learn everything to become productive quickly then I'd be happy to merge. 😃

@kas
Copy link
Contributor Author

kas commented Jun 22, 2016

Hey @chrisvfritz,
I made changes like you requested. Although I don't necessarily think that more implies that Vue devs are more productive -- I am noticing Vue is improving my workflow more so than Angular 😆.

I appreciate you looking into the pull request, please let me know what you think!

@chrisvfritz chrisvfritz merged commit 45445f1 into vuejs:master Jun 22, 2016
kazupon pushed a commit to kazupon/vuejs.org that referenced this pull request Oct 1, 2017
@re-fort @kazupon
Add html div tag (vuejs#324)
deafedb 
* Add a HTML div tag (vuejs#1080) (vuejs#1088)

* Update date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kas @chrisvfritz