Skip to content

add warnings about using arrow functions on instance properties #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chrisvfritz
Copy link
Contributor

@LinusBorg What do you think?

Copy link
Member

@LinusBorg LinusBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@chrisvfritz chrisvfritz merged commit b055026 into vuejs:master Oct 3, 2016
dingyiming added a commit to volksbright/document-standard-vue that referenced this pull request Oct 4, 2016
* master:
  Revert "Master" (vuejs#462)
  Master (vuejs#460)
  Update link to Karma (vuejs#458)
  Explicitly note on `events` opt deprecation (fixes vuejs#436) (vuejs#453)
  remove wording about not including a benchmark from the react team
  Set the background-color to white. (vuejs#452)
  fix capitalizion typo in migration guide
  add literal modifier for directives to migration guide
  fix typo in interpolation within attributes in migration guide
  update dynamic binding example in guide intro
  add named slot to render function guide
  add warnings about using arrow functions on instance properties (vuejs#448)
  fix links to single-file components - fixes vuejs#446
  add note about two-way directives, linking to two-way filters example
  update two-filters example in migration guide
  Same word used multiple times in a sentence (vuejs#444)
  improve $data instance property API docs (vuejs#445)

# Conflicts:
#	src/guide/index.md
#	src/guide/installation.md
#	src/guide/instance.md
#	src/guide/render-function.md
#	src/guide/unit-testing.md
Peter-WF pushed a commit to Peter-WF/vuefe.github.io that referenced this pull request Nov 18, 2016
Peter-WF pushed a commit to Peter-WF/vuefe.github.io that referenced this pull request Nov 18, 2016
* master:
  Revert "Master" (vuejs#462)
  Master (vuejs#460)
  Update link to Karma (vuejs#458)
  Explicitly note on `events` opt deprecation (fixes vuejs#436) (vuejs#453)
  remove wording about not including a benchmark from the react team
  Set the background-color to white. (vuejs#452)
  fix capitalizion typo in migration guide
  add literal modifier for directives to migration guide
  fix typo in interpolation within attributes in migration guide
  update dynamic binding example in guide intro
  add named slot to render function guide
  add warnings about using arrow functions on instance properties (vuejs#448)
  fix links to single-file components - fixes vuejs#446
  add note about two-way directives, linking to two-way filters example
  update two-filters example in migration guide
  Same word used multiple times in a sentence (vuejs#444)
  improve $data instance property API docs (vuejs#445)

# Conflicts:
#	src/guide/index.md
#	src/guide/installation.md
#	src/guide/instance.md
#	src/guide/render-function.md
#	src/guide/unit-testing.md
@qwexvf
Copy link

qwexvf commented Jan 10, 2017

Thanks for this. i was like wtf? because of that. in some cases you can't really use arrow keys.

kazupon pushed a commit to kazupon/vuejs.org that referenced this pull request Nov 24, 2017
* Update directive documentation with tip relating to v-html and scoped styles

vuejs@604c9da

* Update date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants