Multiple field order by #2562
Merged
Multiple field order by #2562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53bb214 to
eb9e0c9
Compare
|
Ping @yyx990803 |
|
|
||
| // sort on a copy to avoid mutating original array | ||
| return arr.slice().sort(function (a, b) { | ||
| return recursiveCompare(a, b, 0) |
There was a problem hiding this comment.
we can jsut sort(recursiveCompare) if we do i = i || 0 in it right? Otherwise LGTM.
eb9e0c9 to
04a213b
Compare
|
@yyx990803 Thanks for the update, I didn't think about the unnecessary function call 😄 . I fixed that and also squashed everything into a single commit. I made a backup in case you prefer it the other way, just tell me if you want me to switch back to the 4 commits version 😉 |
|
👍 good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is refers to the feature request #2518
I replaced the deconstructing array with a simple array because it makes it easier to use an array from data or computed properties:
files | orderBy sortKeysinstead offiles | orderBy 'name' 'size'withsortKeys = ['name', 'size']. Tell me your thoughts about it