Skip to content

Support for mutiple class names as key (close #2571) #2581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Support for mutiple class names as key (close #2571) #2581

wants to merge 1 commit into from

Conversation

phanan
Copy link
Member

@phanan phanan commented Mar 29, 2016

This commit adds support for using multiple class names as key when specifying a :class object, for example <div :class="{ 'a b c': flag }">. Previously, doing so will trigger an uncaught InvalidCharacterError, as spaces are not allowed in DOM tokens. Feature request #2571 should also be satisfied by this commit.

This commit adds support for using multiple class names as key when
specifying a `:class` object, for example `<div :class="{ 'a b c': flag
}">`. Previously, doing so will trigger an uncaught InvalidCharacterError, as
spaces are not allowed in DOM tokens.
Feature request #2571 should also be satisfied by this commit.
@yyx990803
Copy link
Member

We also need to handle removeClass for the same if we are going this route. I think it's better to handle this inside directives/internal/class.js and add related test cases for the directive.

@phanan
Copy link
Member Author

phanan commented Mar 29, 2016

Oh right. I'll look into that.

@phanan
Copy link
Member Author

phanan commented Mar 29, 2016

Let me close this and use a proper, updated, branch instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants