Skip to content

Add spm support #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add spm support #283

wants to merge 1 commit into from

Conversation

afc163
Copy link

@afc163 afc163 commented May 29, 2014

A nicer package manager: http://spmjs.io
Documentation: http://spmjs.io/documentation

http://spmjs.io/package/vue

It is a package manager based on Sea.js which is a popular module loader in China.

spmjs focus in browser side. We supply a complete lifecycle managment of package by using spm.

If you need ownership of vue in spmjs, I can add it for your account after signing in http://spmjs.io.

@afc163 afc163 mentioned this pull request May 29, 2014
Closed
@yyx990803
Copy link
Member

Hmm, I'd like to support spm, but a few issues (as have been raised by other package authors):

  1. Could .spmignore be just an ignore field under the spm namespace in package.json? I don't really want to add an extra dot file. It seems this has been a pretty big issue for package authors to adopt spm.
  2. I only show badges that are related to the build/test status, so no package badges please.

@afc163 afc163 mentioned this pull request May 30, 2014
Closed
@afc163
Copy link
Author

afc163 commented Jun 11, 2014

Now we support ignore field in package.json, and remove badge in this PR.

yyx990803
yyx990803 reviewed Jun 19, 2014
View reviewed changes
package.json
"examples",
"task",
"test"
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please follow the ignore patterns in the project's bower.json (plus dist)?

@afc163
Copy link
Author

afc163 commented Jun 20, 2014

package.json is useful for spm install so we don't ignore it. Except that, the ignore is the same as bower.json now.

@yyx990803
Copy link
Member

Looks good to merge. One final thing: can you point the PR to the dev branch instead? You might need to close this one and open a new PR.

@afc163 afc163 mentioned this pull request Jun 23, 2014
Merged
@afc163
Copy link
Author

afc163 commented Jun 23, 2014

https://github.com/yyx990803/vue/pull/326

@afc163 afc163 closed this Jun 23, 2014
Hanks10100 pushed a commit to Hanks10100/vue that referenced this pull request May 6, 2018
@aOrz
fix: vuejs#283
e6e3b53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afc163 @yyx990803