Fix ViewModel.require with component@1.0.0 #305
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
component/builder2.js rewrites `require` calls during the build step, therefore it's not possible to require a module dynamically. Added a list of internal modules that are exposed for plugins.
|
Looks good - can you point this to the |
|
Not sure how to do that, should I make a new pull request ? |
|
Yeah, just make a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
component/builder2.js rewrites
requirecalls during the build step, therefore it's not possible to require a module dynamically.Added a list of internal modules that are exposed for plugins.
Not sure if we should add this in
main.jsor in a different module. Let me know