fix props validation fails (#3183) #3193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -122,6 +123,9 @@ export function compileProps (el, propOptions, vm) { | |||
| } else if ((value = getAttr(el, attr)) !== null) { | |||
| // has literal binding! | |||
| prop.raw = value | |||
| } else if (propsData && (value = propsData[attr]) !== null) { | |||
There was a problem hiding this comment.
attr is hyphenated, but the user may use camelCase prop names in propsData. We need to check both propsData[attr] and propsData[name].
There was a problem hiding this comment.
Maybe user can only use camelCase propsData[path]?
There was a problem hiding this comment.
True, that makes more sense. then we should just replace attr with name here.
6d53393 to
757da7d
Compare
|
Thanks review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.