Skip to content

use a simple expression parser instead of regexp to parse directive #3734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2016
Merged

use a simple expression parser instead of regexp to parse directive #3734

merged 1 commit into from
Sep 23, 2016

Conversation

defcc
Copy link
Member

@defcc defcc commented Sep 23, 2016

Use a state machine based expression parser to parse the directive.

fix #3210 and #3214 #

@yyx990803 yyx990803 merged commit b2ab9fa into vuejs:dev Sep 23, 2016
@yyx990803
Copy link
Member

Thanks and nice job! 👍

@libmw
Copy link

libmw commented Sep 24, 2016

@defcc good job!

@defcc defcc mentioned this pull request Sep 24, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parsing object as a filter argument fails with spaces inside
3 participants
@defcc @yyx990803 @libmw