fix directive sort compare #3776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! LGTM |
|
Ok, current test case seems not to fully cover the code. I will try to update the test case soon |
yyx990803
reviewed
Sep 27, 2016
| } | ||
| array.push(dir) | ||
| } | ||
|
|
||
| var index = 0 | ||
| var priorities = Object.keys(groupedMap).sort(function (a, b) { | ||
| var priorities = keys.sort(function (a, b) { |
There was a problem hiding this comment.
sort is in-place, so we can just name this array priorities from the start, no need to assign a separate variable.
There was a problem hiding this comment.
thanks, I have updated the code :)
|
forgot it. I will fix it later today |
|
Thanks! 👍 |
|
Thanks, fixed the bug 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3768
Object.keys(groupedMap) returns an array whose elements are strings, so it breaks the sort function.